Optimize factory usage for analytics build serializer

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-analytics-build-serializer-spec into master

MR Content: title Optimize factory usage

What does this MR do and why?

This MR replaces create with build_stubbed in spec/serializers/analytics_build_serializer_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/serializers/analytics_build_serializer_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 1.7069999999999999s (8.5% of total time)

After optimization:

  • Factory time: 0.037s (0.22% of total time)

🚀 Improvement:

  • Factory time reduced by: 1.67s
  • Factory time percentage reduced by: 8.28%
  • Overall factory usage improvement: 97.8%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 1.1856370000023162 seconds
.[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:01.649

AnalyticsBuildSerializer (./spec/serializers/analytics_build_serializer_spec.rb:5) (5 records created, 00:01.649)
  contains important elements of analyticsBuild (./spec/serializers/analytics_build_serializer_spec.rb:11) – 5 records created, 00:01.649




Finished in 14.64 seconds (files took 13.81 seconds to load)
1 example, 0 failures

[TEST PROF INFO] Time spent in factories: 00:01.656 (9.11% of total time)

Factory time before the update 

[TEST PROF INFO] Time spent in factories: 00:01.707 (8.5% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.037 (0.22% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports