Optimize factory usage for configuration helper

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-configuration-helper-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in spec/helpers/projects/security/configuration_helper_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/helpers/projects/security/configuration_helper_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 0.48s (2.68% of total time)

After optimization:

  • Factory time: 0.006s (0.04% of total time)

🚀 Improvement:

  • Factory time reduced by: 0.474s
  • Factory time percentage reduced by: 2.64%
  • Overall factory usage improvement: 98.8%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 0.9712490000019898 seconds
..[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:00.470

Projects::Security::ConfigurationHelper (./spec/helpers/projects/security/configuration_helper_spec.rb:5) (2 records created, 00:00.470)
  is expected to eq "https://about.gitlab.com/pricing" (./spec/helpers/projects/security/configuration_helper_spec.rb:11) – 2 records created, 00:00.470




Finished in 13.64 seconds (files took 13.86 seconds to load)
2 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:00.477 (2.74% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.006 (0.04% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports