Optimize factory usage for notifications helper (!228818) · Merge requests · GitLab.org / GitLab

What does this MR do and why?

This MR replaces create with build_stubbed in spec/helpers/notifications_helper_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec spec/helpers/notifications_helper_spec.rb.

Factory Usage Optimization Results

Before optimization:

Factory time: 1.567s (8.67% of total time)

After optimization:

Factory time: 0.042s (0.26% of total time)

🚀 Improvement:

Factory time reduced by: 1.352s
Factory time percentage reduced by: 8.41%
Overall factory usage improvement: 97.3%

Factory Doctor Output

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache

Test environment set up in 1.1799079999982496 seconds
..........[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 2
Total wasted time: 00:01.475

NotificationsHelper (./spec/helpers/notifications_helper_spec.rb:5) (12 records created, 00:01.475)
  is expected to eq "owner_disabled" (./spec/helpers/notifications_helper_spec.rb:21) – 6 records created, 00:01.225
  is expected to eq "watch" (./spec/helpers/notifications_helper_spec.rb:22) – 6 records created, 00:00.250




Finished in 14.68 seconds (files took 13.52 seconds to load)
10 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:01.520 (8.34% of total time)

Factory time after update

[TEST PROF INFO] Time spent in factories: 00:00.042 (0.26% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Optimize factory usage for notifications helper