Skip to content
Snippets Groups Projects

Force 2FA code input to show only numeric keyboard on touch devices

Merged Kushal Pandya requested to merge kp-force-numeric-only-keyboard-2fa-input into master
All threads resolved!

What does this MR do?

This MR adds inputmode to 2FA code input field such that it forces touchscreen device to show a numeric-only keyboard for code input (as 2FA codes are numeric only). Inspiration for this MR comes from this article.

Screenshots

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related Issue

#20605 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @iamphill

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes resolved all threads

    resolved all threads

  • merged

  • Phil Hughes mentioned in commit 7c15fffd

    mentioned in commit 7c15fffd

  • Kushal Pandya changed the description

    changed the description

  • mentioned in issue #20605 (closed)

  • mentioned in issue #196812 (closed)

  • Kushal Pandya mentioned in commit 5681fecf

    mentioned in commit 5681fecf

  • Kushal Pandya mentioned in issue #198352

    mentioned in issue #198352

  • Kushal Pandya mentioned in merge request !23514 (merged)

    mentioned in merge request !23514 (merged)

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • mentioned in issue #207562 (closed)

  • Please register or sign in to reply
    Loading