Optimize factory usage for dast profile show

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-dast-profile-show into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 1.8719999999999999s (9.51% of total time)

After optimization:

  • Factory time: 0.06s (0.34% of total time)

🚀 Improvement:

  • Factory time reduced by: 1.812s
  • Factory time percentage reduced by: 9.17%
  • Overall factory usage improvement: 96.8%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.73 seconds...

Test environment set up in 2.1898709999513812 seconds
....[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 4
Total wasted time: 00:01.890

projects/security/dast_profiles/show (./ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb:5) (12 records created, 00:01.890)
  renders Vue app root (./ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb:11) – 3 records created, 00:01.209
  passes new dast site profile path (./ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb:15) – 3 records created, 00:00.185
  passes new dast scanner profile path (./ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb:19) – 3 records created, 00:00.162
  passes project's full path (./ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb:23) – 3 records created, 00:00.332




Finished in 14.08 seconds (files took 16.11 seconds to load)
4 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:01.899 (10.29% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.060 (0.34% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports