Optimize factory usage for show.html.haml_spec

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-show.html.haml-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/views/groups/hook_logs/show.html.haml_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/views/groups/hook_logs/show.html.haml_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 0.614s (3.17% of total time)

After optimization:

  • Factory time: 0.011s (0.07% of total time)

🚀 Improvement:

  • Factory time reduced by: 0.603s
  • Factory time percentage reduced by: 3.1%
  • Overall factory usage improvement: 98.2%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.836 seconds...

Test environment set up in 2.3490400000009686 seconds
.[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:00.686

groups/hook_logs/show (./ee/spec/views/groups/hook_logs/show.html.haml_spec.rb:5) (6 records created, 00:00.686)
  renders the request details page (./ee/spec/views/groups/hook_logs/show.html.haml_spec.rb:16) – 6 records created, 00:00.686




Finished in 14.75 seconds (files took 16.04 seconds to load)
1 example, 0 failures

[TEST PROF INFO] Time spent in factories: 00:00.697 (3.67% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.011 (0.07% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports