Optimize factory usage for scanner_entity_spec

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-scanner-entity-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 1.3439999999999999s (6.75% of total time)

After optimization:

  • Factory time: 0.043s (0.27% of total time)

🚀 Improvement:

  • Factory time reduced by: 1.301s
  • Factory time percentage reduced by: 6.48%
  • Overall factory usage improvement: 96.8%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.793 seconds...

Test environment set up in 2.1842259999830276 seconds
.[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:01.447

Vulnerabilities::ScannerEntity (./ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb:5) (4 records created, 00:01.447)
  contains required fields (./ee/spec/serializers/vulnerabilities/scanner_entity_spec.rb:15) – 4 records created, 00:01.447




Finished in 15.21 seconds (files took 16.01 seconds to load)
1 example, 0 failures

Randomized with seed 50167

[TEST PROF INFO] Time spent in factories: 00:01.458 (7.48% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.043 (0.27% of total time)

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports