Raise on failure by default in wait/retry in QA tests
What does this MR do?
Many cases of flaky tests have been caused by allowing the test to continue even after a precondition isn't satisfied.
This change makes it harder for that to happen by raising an error if the condition of a wait/retry block isn't met.
Part of #39208 (closed)
Closes gitlab-qa#282 (closed)
Depends on !22861 (merged)
Does this MR meet the acceptance criteria?
Conformity
Edited by Mark Lapierre