Optimize factory usage for scim_oauth_access_token_entity

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-scim-oauth-access-token-entity-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/serializers/scim_oauth_access_token_entity_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/serializers/scim_oauth_access_token_entity_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 0.068s (0.37% of total time)

After optimization:

  • Factory time: 0.01s (0.07% of total time)

🚀 Improvement:

  • Factory time reduced by: 0.058s
  • Factory time percentage reduced by: 0.3%
  • Overall factory usage improvement: 85.3%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.693 seconds...

Test environment set up in 1.963004000019282 seconds
..[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:00.052

ScimOauthAccessTokenEntity (./ee/spec/serializers/scim_oauth_access_token_entity_spec.rb:5) (2 records created, 00:00.052)
  exposes the token (./ee/spec/serializers/scim_oauth_access_token_entity_spec.rb:16) – 2 records created, 00:00.052




Finished in 12.76 seconds (files took 15.48 seconds to load)
2 examples, 0 failures

Randomized with seed 36051

[TEST PROF INFO] Time spent in factories: 00:00.073 (0.43% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.010 (0.07% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports