Optimize factory usage for oncall_schedule_entity_spec

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-oncall-schedule-entity-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 1.509s (8.9% of total time)

After optimization:

  • Factory time: 0.044s (0.25% of total time)

🚀 Improvement:

  • Factory time reduced by: 1.465s
  • Factory time percentage reduced by: 8.65%
  • Overall factory usage improvement: 97.1%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.83 seconds...

Test environment set up in 2.2624910000013188 seconds
.[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:01.404

IncidentManagement::OncallScheduleEntity (./ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb:5) (4 records created, 00:01.404)
  includes oncall schdule attributes (./ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb:13) – 4 records created, 00:01.404




Finished in 15.47 seconds (files took 16.25 seconds to load)
1 example, 0 failures

Randomized with seed 18135

[TEST PROF INFO] Time spent in factories: 00:01.413 (7.19% of total time)

Factory time after update 

[TEST PROF INFO] Time spent in factories: 00:00.044 (0.25% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports