Optimize factory usage for prevent forking helper spec

Marcos Rocharequested to merge
mc_rocha-optimize-factory-usage-prevent-forking-helper-spec into master

What does this MR do and why?

This MR replaces create with build_stubbed in ee/spec/helpers/prevent_forking_helper_spec.rb to optimize the factory usage as recommended in our handbook. This spec is part of the list .rubocop_todo/rspec/factory_bot/avoid_create.yml. It was verified that database persistence is not needed using the factory doctor command FDOC=1 bin/rspec ee/spec/helpers/prevent_forking_helper_spec.rb.

Factory Usage Optimization Results

Before optimization:

  • Factory time: 0.573s (3.08% of total time)

After optimization:

  • Factory time: 0.01s (0.07% of total time)

🚀 Improvement:

  • Factory time reduced by: 0.563s
  • Factory percentage reduced by: 3.01%
  • Overall factory usage improvement: 98.3%

Factory Doctor Output 

[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
==> Using precompiled Gitaly binaries from cache
==> Go projects set up in 0.813 seconds...

Test environment set up in 2.702071999956388 seconds
.[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 1
Total wasted time: 00:00.484

PreventForkingHelper (./ee/spec/helpers/prevent_forking_helper_spec.rb:5) (4 records created, 00:00.484)
  calls proper ability method (./ee/spec/helpers/prevent_forking_helper_spec.rb:9) – 4 records created, 00:00.484




Finished in 13.4 seconds (files took 16.41 seconds to load)
1 example, 0 failures

[TEST PROF INFO] Time spent in factories: 00:00.496 (2.81% of total time)

This MR also adds the missing feature category in this spec.

References

Relates to: #378910.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports