Fix upload redirections when project has moved

changed milestone to %12.7

added Stuff that should Just Work devopsplan typebug labels

assigned to @mkozono and unassigned @stanhu

changed the description

mentioned in issue #196232 (closed)

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Zamir Martins Filho (`@zmartins`)	Nick Thomas (`@nick.thomas`)

Generated by Danger

added 1 commit

ac09ef5c - Redirect to the canonical project upload path

Compare with previous version

resolved all threads

added 1 commit

ca2bc292 - Redirect to the canonical project upload path

Compare with previous version

I think this also affects group uploads since they can be redirected. These are the routes that have a :filename:

                                                                   GET                   /uploads/-/system/:model/:mounted_as/:id/:filename(.:format)                                                    uploads#show {:model=>/note|user|group|project/, :mounted_as=>/avatar|attachment/, :filename=>/[^\/]+/}
                                                                   GET                   /uploads/-/system/:model/:id/:secret/:filename(.:format)                                                        uploads#show {:model=>/personal_snippet|user/, :id=>/\d+/, :filename=>/[^\/]+/}
                                                                   GET                   /uploads/-/system/temp/:secret/:filename(.:format)                                                              uploads#show {:filename=>/[^\/]+/}
                                                 appearance_upload GET                   /uploads/-/system/:model/:mounted_as/:id/:filename(.:format)                                                    uploads#show {:model=>/appearance/, :mounted_as=>/logo|header_logo|favicon/, :filename=>/.+/}
                                                                   GET                   /uploads/:namespace_id/:project_id/:secret/:filename(.:format)                                                  projects/uploads#show {:namespace_id=>/[a-zA-Z.0-9_\-]+/, :project_id=>/[a-zA-Z.0-9_\-]+/, :filename=>/[^\/]+/}
                                                                   GET                   /files/note/:id/:filename(.:format)                                                                             redirect(301, uploads/note/attachment/%{id}/%{filename}) {:filename=>/[^\/]+/}
                                                show_group_uploads GET                   /groups/*group_id/-/uploads/:secret/:filename(.:format)                                                         groups/uploads#show {:filename=>/[^\/]+/}
                                    show_namespace_project_uploads GET                   /*namespace_id/:project_id/uploads/:secret/:filename(.:format)                                                  projects/uploads#show {:project_id=>/(?!((?i-mx:\-|badges|blame|blob|builds|commits|create|create_dir|edit|environments\/folders|files|find_file|gitlab\-lfs\/objects|info\/lfs\/objects|new|preview|raw|refs|tree|update|wikis))\/)(?-mix:(?:[a-zA-Z0-9_\.][a-zA-Z0-9_\-\.]*)(?-mix:(?<!\.git|\.atom)))/, :namespace_id=>/(?-mix:(?!((?i-mx:\-|\.well\-known|404\.html|422\.html|500\.html|502\.html|503\.html|abuse_reports|admin|api|apple\-touch\-icon\-precomposed\.png|apple\-touch\-icon\.png|assets|autocomplete|ci|dashboard|deploy\.html|explore|favicon\.ico|favicon\.png|files|groups|health_check|help|import|invites|jwt|login|notification_settings|oauth|profile|projects|public|robots\.txt|s|search|sent_notifications|slash\-command\-logo\.png|snippets|unsubscribes|uploads|users|v2))\/)(?-mix:(?:[a-zA-Z0-9_\.][a-zA-Z0-9_\-\.]*[a-zA-Z0-9_\-]|[a-zA-Z0-9_])(?-mix:(?<!\.git|\.atom))))(?:\/(?!(?i-mx:\-|badges|blame|blob|builds|commits|create|create_dir|edit|environments\/folders|files|find_file|gitlab\-lfs\/objects|info\/lfs\/objects|new|preview|raw|refs|tree|update|wikis)\/)(?-mix:(?:[a-zA-Z0-9_\.][a-zA-Z0-9_\-\.]*[a-zA-Z0-9_\-]|[a-zA-Z0-9_])(?-mix:(?<!\.git|\.atom))))*/, :filename=>/[^\/]+/}