Remove git_ref_validator_custom_validation feature flag

Vasilii Iakliushinrequested to merge
590000-removee-ff into master

What does this MR do and why?

Contributes to #590000 (closed)

Problem

The git_ref_validator_custom_validation feature flag was used to derisk the migration from Rugged-based ref name validation to a custom implementation. The flag has been enabled on production and verified stable.

Solution

Remove the feature flag and make custom validation the only code path. Delete legacy Rugged-based validation methods and the FF YAML definition. Flatten and simplify the spec by inlining shared_examples and merging test data that was previously split across FF-conditional contexts.

References

Screenshots or screen recordings

Not applicable — no UI changes.

How to set up and validate locally

  1. Run bundle exec rspec spec/lib/gitlab/git_ref_validator_spec.rb — all 172 examples should pass
  2. Run bundle exec rspec spec/services/tags/create_service_spec.rb — all 8 examples should pass
  3. Verify no remaining references: grep -r git_ref_validator_custom_validation . should return nothing

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports