Skip to content
Snippets Groups Projects

Add milestones to roadmap

Merged Florie Guibert requested to merge 6802-show-milestones-in-roadmap into master
All threads resolved!

What does this MR do?

Adds milestones to Roadmap. This MR introduces :milestones_in_roadmap feature flag which needs to be turned on to see milestones on roadmap. This MR also contains some refactoring of roadmap utils and mixins that were specific to epics and needed to be made more generic to be used for milestones.

Screenshots

Screenshot_from_2020-02-20_11-06-38

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Issue #6802 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @fguibert As an aside, if you find that bootstrap doesn't have something, you can always add a new utility/common class in app/assets/stylesheets/framework/common.scss or utilities.scss

  • Florie Guibert added 7 commits

    added 7 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 487 commits

    added 487 commits

    Compare with previous version

  • Laura Montemayor
  • Laura Montemayor
  • Laura Montemayor
  • Laura Montemayor
  • Laura Montemayor
  • Florie Guibert added 170 commits

    added 170 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Laura Montemayor
  • Florie Guibert added 200 commits

    added 200 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 191 commits

    added 191 commits

    Compare with previous version

    • Resolved by Kushal Pandya

      @kushalpandya Hey Kushal! Could you please give this MR a look? I've already reviewed most of it, and there are some unresolved discussions for you to take a look at. I will finish my review (mostly left surrounding optimizing CSS) as soon as I can on Monday. Thank you! :smile:

  • Laura Montemayor
  • Kushal Pandya
  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Laura Montemayor
  • Jose Ivan Vargas
  • Jose Ivan Vargas
  • Jose Ivan Vargas
  • Jose Ivan Vargas
  • Jose Ivan Vargas
  • Jose Ivan Vargas
    • Author Maintainer
      Resolved by Florie Guibert

      @uhlexsis There are a few UX questions here about following our system guidelines. Following our initial conversation about this feature, I customised the CSS to squish how we display milestones as we are not initially stacking them. Could you enlighten us on some questions here and give this a UX review? Thanks

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Laura Montemayor unassigned @lauraMon

    unassigned @lauraMon

  • Florie Guibert assigned to @lauraMon

    assigned to @lauraMon

  • Laura Montemayor approved this merge request

    approved this merge request

  • Laura Montemayor unassigned @lauraMon

    unassigned @lauraMon

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • 2 Warnings
    :warning: This merge request is quite big (more than 1549 lines changed), please consider splitting it into multiple merge requests.
    :warning: You have edited karma spec files. Please consider migrating them to jest.

    Edited karma files

    You have edited the following karma spec files. Please consider migrating them to jest:

    • ee/spec/javascripts/roadmap/components/epic_item_spec.js
    • ee/spec/javascripts/roadmap/components/roadmap_app_spec.js
    • ee/spec/javascripts/roadmap/components/roadmap_shell_spec.js
    • ee/spec/javascripts/roadmap/mixins/months_preset_mixin_spec.js
    • ee/spec/javascripts/roadmap/mixins/quarters_preset_mixin_spec.js
    • ee/spec/javascripts/roadmap/mixins/weeks_preset_mixin_spec.js
    • ee/spec/javascripts/roadmap/mock_data.js
    • ee/spec/javascripts/roadmap/store/actions_spec.js
    • ee/spec/javascripts/roadmap/store/mutations_spec.js
    • ee/spec/javascripts/roadmap/utils/roadmap_item_utils_spec.js

    In order to align with our Iteration value, migration can also be done as a follow-up.

    For more information: Jestodus epic

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    frontend Olena HK. (@ohoral) Fatih Acet (@fatihacet)
    backend Jeremy Jackson (@jejacks0n) James Lopez (@jameslopez)

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Florie Guibert added 1059 commits

    added 1059 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 359 commits

    added 359 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Alexis Ginsberg approved this merge request

    approved this merge request

  • Kushal Pandya
  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya approved this merge request

    approved this merge request

  • Florie Guibert added 635 commits

    added 635 commits

    Compare with previous version

  • Florie Guibert added 1 commit

    added 1 commit

    Compare with previous version

  • Kushal Pandya resolved all threads

    resolved all threads

  • merged

  • Kushal Pandya mentioned in commit c943774f

    mentioned in commit c943774f

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • Please register or sign in to reply
    Loading