Add milestones to roadmap
What does this MR do?
Adds milestones to Roadmap.
This MR introduces :milestones_in_roadmap
feature flag which needs to be turned on to see milestones on roadmap.
This MR also contains some refactoring of roadmap utils and mixins that were specific to epics and needed to be made more generic to be used for milestones.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Issue #6802 (closed)
Merge request reports
Activity
changed milestone to %12.7
assigned to @fguibert
added 2 commits
changed milestone to %12.8
added missed:12.7 label
added 3584 commits
-
6bf2429b...a618e6e0 - 3573 commits from branch
master
- 08da8ebc - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 1809fca8 - Show milestones in Roadmap
- 9bb81825 - stash
- 420d836e - Show milestones in Roadmap
- 1e8c17b3 - Show milestones in Roadmap
- 1f7e0aba - Show milestones in Roadmap
- f4a79fd3 - Milestones in Roadmap - Remove all absolute positioning
- 6ab37d66 - Add Milestones to Roadmap
- b1964c92 - Add Milestones to Roadmap
- ad6fdd60 - Add Milestones to Roadmap
- d47c7f99 - Add milestones to roadmap
Toggle commit list-
6bf2429b...a618e6e0 - 3573 commits from branch
added 10 commits
- 4111ab17 - Show milestones in Roadmap
- 43ad1f58 - Show milestones in Roadmap
- 083eb199 - Show milestones in Roadmap
- 4670728c - Show milestones in Roadmap
- 4689a44d - Milestones in Roadmap - Remove all absolute positioning
- 8bff1438 - Add Milestones to Roadmap
- 77e5e28e - Add Milestones to Roadmap
- 13e69fd8 - Add Milestones to Roadmap
- 37450489 - Add milestones to roadmap
- 9ac01600 - Add milestones to roadmap
Toggle commit listadded typefeature label
added 608 commits
-
f232f34c...ae492e65 - 598 commits from branch
master
- f4a668d7 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- dda76587 - Show milestones in Roadmap
- c1ba71b3 - Show milestones in Roadmap
- 5158fa52 - Show milestones in Roadmap
- 48ea3c88 - Show milestones in Roadmap
- ed939e89 - Add Milestones to Roadmap
- 4fdcbd5b - Add Milestones to Roadmap
- ce91e056 - Add Milestones to Roadmap
- 69284ffe - Add milestones to roadmap
- bbb87c97 - Add milestones to roadmap
Toggle commit list-
f232f34c...ae492e65 - 598 commits from branch
added 1163 commits
-
bbb87c97...df90667f - 1154 commits from branch
master
- 0ab0db60 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 1e161083 - Show milestones in Roadmap
- 3cad6e3b - Show milestones in Roadmap
- aaea63fd - Show milestones in Roadmap
- bdd3225c - Add Milestones to Roadmap
- 902465a2 - Add Milestones to Roadmap
- 840554c7 - Add milestones to roadmap
- 8f8ec0b8 - Add milestones to roadmap
- e1240565 - Add Milestones in Roadmap
Toggle commit list-
bbb87c97...df90667f - 1154 commits from branch
added 38 commits
-
e1240565...c299e39f - 29 commits from branch
master
- 4f1116b2 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 9edcb23a - Show milestones in Roadmap
- 0de08810 - Show milestones in Roadmap
- c1bdfc9f - Show milestones in Roadmap
- ae90deb7 - Add Milestones to Roadmap
- 97fff84e - Add Milestones to Roadmap
- a31ddbb9 - Add milestones to roadmap
- e739330b - Add milestones to roadmap
- 69694232 - Add Milestones in Roadmap
Toggle commit list-
e1240565...c299e39f - 29 commits from branch
added 93 commits
-
69694232...a8603723 - 84 commits from branch
master
- ec114fa7 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 49da699b - Show milestones in Roadmap
- 08f231c0 - Show milestones in Roadmap
- 4e4cd8ef - Show milestones in Roadmap
- 7a5133ad - Add Milestones to Roadmap
- 9da1fbfe - Add Milestones to Roadmap
- 7cdfd09f - Add milestones to roadmap
- b163f7ce - Add milestones to roadmap
- 244af008 - Add Milestones in Roadmap
Toggle commit list-
69694232...a8603723 - 84 commits from branch
@lauraMon Can I get frontend review please?
@alexbuijs Can I get backend review please? I suppose this is mostly about the feature flag.
assigned to @lauraMon and @alexbuijs
- Resolved by Laura Montemayor
@alexbuijs Can I get backend review please? I suppose this is mostly about the feature flag.
Sure! Yes, that's the only line of ruby code. LGTM! Approving and assigning to @godfat.
Btw, the title of the MR stills says WIP, you might want to remove that, as it is ready for review now. And probably you should change the milestone to 12.9, since 12.8 finished a couple of days ago.
assigned to @godfat and unassigned @alexbuijs
unassigned @godfat
changed milestone to %12.9
added missed:12.8 label
added workflowin review label and removed workflowready for development label
mentioned in merge request !25774 (merged)
mentioned in merge request !25778 (merged)
added feature flag label
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
@fguibert As an aside, if you find that bootstrap doesn't have something, you can always add a new utility/common class in
app/assets/stylesheets/framework/common.scss
orutilities.scss
added 487 commits
-
10b93f00...8705340a - 478 commits from branch
master
- 16a8c5f3 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- ca2da0d2 - Show milestones in Roadmap
- 6dfb9b6b - Show milestones in Roadmap
- 0a20549d - Add Milestones to Roadmap
- e0b2cf36 - Add milestones to roadmap
- 5a8e74ac - Add milestones to roadmap
- d9aa85c5 - Add Milestones in Roadmap
- 81d3db31 - Add Milestones in Roadmap
- 67c6570e - Add Milestones in Roadmap
Toggle commit list-
10b93f00...8705340a - 478 commits from branch
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Laura Montemayor
- Resolved by Laura Montemayor
- Resolved by Laura Montemayor
- Resolved by Laura Montemayor
- Resolved by Florie Guibert
- Resolved by Laura Montemayor
- Resolved by Florie Guibert
- Resolved by Laura Montemayor
added 170 commits
-
67c6570e...a01fb250 - 161 commits from branch
master
- 8db374f6 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 56561751 - Show milestones in Roadmap
- 8c635153 - Show milestones in Roadmap
- 92692be1 - Add Milestones to Roadmap
- 5c88ac4b - Add milestones to roadmap
- 09453522 - Add milestones to roadmap
- c515a70f - Add Milestones in Roadmap
- 6e058bac - Add Milestones in Roadmap
- f68f0b35 - Add Milestones in Roadmap
Toggle commit list-
67c6570e...a01fb250 - 161 commits from branch
- Resolved by Laura Montemayor
added 200 commits
-
11424b35...abe7a9ba - 191 commits from branch
master
- f5375e27 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- dd683e5e - Show milestones in Roadmap
- 1cb0d9c8 - Show milestones in Roadmap
- dc0778aa - Add Milestones to Roadmap
- c495a01c - Add milestones to roadmap
- 1702a409 - Add milestones to roadmap
- 69f2b2ff - Add Milestones in Roadmap
- cd72d2b1 - Add Milestones in Roadmap
- 792240ca - Add Milestones in Roadmap
Toggle commit list-
11424b35...abe7a9ba - 191 commits from branch
added database databasereview pending labels
added 191 commits
-
81c81ea0...dd1aedef - 182 commits from branch
master
- 7b504f7b - Add milestones to roadmap - GraphQL mock milestones - vuex state
- c9789691 - Show milestones in Roadmap
- 5fcfc308 - Show milestones in Roadmap
- d9c6e078 - Add Milestones to Roadmap
- 2f3fb6e6 - Add milestones to roadmap
- a7a04ac1 - Add milestones to roadmap
- 39ed6d6f - Add Milestones in Roadmap
- f3150002 - Add Milestones in Roadmap
- 052b5104 - Add Milestones in Roadmap
Toggle commit list-
81c81ea0...dd1aedef - 182 commits from branch
- Resolved by Kushal Pandya
@kushalpandya Hey Kushal! Could you please give this MR a look? I've already reviewed most of it, and there are some unresolved discussions for you to take a look at. I will finish my review (mostly left surrounding optimizing CSS) as soon as I can on Monday. Thank you!
assigned to @kushalpandya
- Resolved by Laura Montemayor
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
- Resolved by Florie Guibert
unassigned @kushalpandya
assigned to @kushalpandya
unassigned @kushalpandya
- Resolved by Laura Montemayor
- Resolved by Jose Ivan Vargas
- Resolved by Florie Guibert
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Jose Ivan Vargas
- Resolved by Florie Guibert
- Resolved by Jeremy Elder
- Resolved by Florie Guibert
@uhlexsis There are a few UX questions here about following our system guidelines. Following our initial conversation about this feature, I customised the CSS to squish how we display milestones as we are not initially stacking them. Could you enlighten us on some questions here and give this a UX review? Thanks
assigned to @uhlexsis
- Resolved by Laura Montemayor
@fguibert Let me know when this is ready and I'll do the approval :) I will unassign myself for now.
removed database databasereview pending labels
2 Warnings This merge request is quite big (more than 1549 lines changed), please consider splitting it into multiple merge requests. You have edited karma spec files. Please consider migrating them to jest. Edited karma files
You have edited the following karma spec files. Please consider migrating them to jest:
ee/spec/javascripts/roadmap/components/epic_item_spec.js
ee/spec/javascripts/roadmap/components/roadmap_app_spec.js
ee/spec/javascripts/roadmap/components/roadmap_shell_spec.js
ee/spec/javascripts/roadmap/mixins/months_preset_mixin_spec.js
ee/spec/javascripts/roadmap/mixins/quarters_preset_mixin_spec.js
ee/spec/javascripts/roadmap/mixins/weeks_preset_mixin_spec.js
ee/spec/javascripts/roadmap/mock_data.js
ee/spec/javascripts/roadmap/store/actions_spec.js
ee/spec/javascripts/roadmap/store/mutations_spec.js
ee/spec/javascripts/roadmap/utils/roadmap_item_utils_spec.js
In order to align with our Iteration value, migration can also be done as a follow-up.
For more information: Jestodus epic
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Olena HK. ( @ohoral
)Fatih Acet ( @fatihacet
)backend Jeremy Jackson ( @jejacks0n
)James Lopez ( @jameslopez
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1059 commits
-
38dc3b0b...2593da37 - 1050 commits from branch
master
- 0d69f681 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 520645f0 - Show milestones in Roadmap
- eff1773d - Show milestones in Roadmap
- 0e6decfe - Add Milestones to Roadmap
- ec2d7940 - Add milestones to roadmap
- ceafcc01 - Add milestones to roadmap
- 44f77c73 - Add Milestones in Roadmap
- 54df39e7 - Add Milestones in Roadmap
- bdef539d - Add Milestones in Roadmap
Toggle commit list-
38dc3b0b...2593da37 - 1050 commits from branch
added 359 commits
-
4b8baecc...b83b085b - 349 commits from branch
master
- e5ecdd83 - Add milestones to roadmap - GraphQL mock milestones - vuex state
- 99fa8605 - Show milestones in Roadmap
- 841c9c25 - Show milestones in Roadmap
- ad5f3948 - Add Milestones to Roadmap
- fe892f61 - Add milestones to roadmap
- 9300a902 - Add milestones to roadmap
- a199c99b - Add Milestones in Roadmap
- d734f7a8 - Add Milestones in Roadmap
- 046e6330 - Add Milestones in Roadmap
- 620de896 - Add milestones to roadmap
Toggle commit list-
4b8baecc...b83b085b - 349 commits from branch
assigned to @kushalpandya
- Resolved by Kushal Pandya
@kushalpandya Back to you for maintainer review, if you have time. Thanks!
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
unassigned @kushalpandya
assigned to @kushalpandya
unassigned @kushalpandya
added 635 commits
-
cefe3f85...982edbcd - 634 commits from branch
master
- e786fede - Add milestones to roadmap
-
cefe3f85...982edbcd - 634 commits from branch
mentioned in commit c943774f
mentioned in merge request gitlab-com/www-gitlab-com!40530 (merged)
added missed:12.8 workflowstaging labels and removed missed:12.8 workflowin review labels
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request gitlab-com/www-gitlab-com!47471 (merged)
added Category:Portfolio Management label
removed Technical Writing label
mentioned in merge request gitlab-com/www-gitlab-com!104172 (merged)
removed Plan [DEPRECATED] label