[Backport 18.8]Fix PG::UniqueViolation in project_daily_statistics sync trigger
What does this MR do and why?
Related: #592642 (closed)
After the project_daily_statistics partitioning table swap in !211916 (merged),
the sync trigger table_sync_function_c237afdf68() copies writes from
the new partitioned table to project_daily_statistics_archived (the
original table). The trigger's INSERT branch performs a plain INSERT
without conflict handling.
When a row for the same (project_id, date) already exists in the
archived table, the trigger raises PG::UniqueViolation, which causes
an HTTP 500 on POST /git-upload-pack. This breaks all CI pipeline
git clone operations after the first fetch per day per project.
This MR adds ON CONFLICT DO NOTHING to the trigger's INSERT branch,
so duplicate rows in the archived table are silently skipped.
Note:
This issue only affects 18.8.x. In 18.9, the archived table and trigger were removed entirely in !219031 (merged).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
- Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
- Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, reach out to a Software Engineer in Test in #s_developer_experience.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.