Stop archiving projects when marking for deletion

Abdul Wadoodrequested to merge
588699-treat-scheduled-deletion-as-archived into master

What does this MR do and why?

This change decouples the archived state from deletion scheduling as part of moving to a state machine model where projects can be in one state (archived OR deletion_scheduled) rather than both.

References

https://handbook.gitlab.com/handbook/engineering/architecture/design-documents/group_and_project_operations_and_state_management/

How to set up and validate locally

  1. Schedule a project for deletion by going to Settings -> General -> Advanced and clicking Delete.
  2. Check the archived state of the project in the Rails console: project.archived, it should be false.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #588699 (closed)

Merge request reports