Skip to content

WIP: Convert Geo Node Form to Vue

Zack Cuddy requested to merge 118841-geo-form-in-js into master

Why WIP

  • Hook up the API => !22392 (merged)
  • This will need to be split up into a few smaller MRs
  • Write Tests

Potential MR Split up

  1. Init Vue application behind a feature flag, :enable_geo_node_form_js => !22815 (merged)
  2. Add core functionality in UI => !23479 (merged)
  3. Add Selective Sync to the UI
  4. Add form validation and API POST/PUT
  5. Remove feature flag, delete feature conditionals and legacy code

What does this MR do?

Closes #118841 (closed)

This MR moves the Geo Node form into the UI. This will allow us to have stronger onBlur and onChange validations as well as properly hidden fields.

The form will now POST to a new endpoint to Create/Edit Nodes.

Significant changes

  1. The interaction with Selective Sync Namespaces is slightly different now (See screenshot). There is a dropdown with a search, instead of a Typeahead search.
  2. The interaction with Selective Sync Shards is slightly different now (See screenshot). There is a dropdown with selectable shards, instead of a selectable text box.

Screenshots

Primary Node Form Secondary Node Form Selective Sync Namespaces Selective Sync Shards
before Primary_Node_Form__Old_ Secondary_Node_Form__Old_ Selective_Sync_Namespaces__Old_ Selective_Sync_Shards__Old_
after Primary_Node_Form__New_ Secondary_Node_Form__New_ Selective_Sync_-Namespaces__New Selective_Sync_Shards__New_

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #118841 (closed)

Edited by Zack Cuddy

Merge request reports