Skip to content

Respect line endings from API calls

Temtaime requested to merge Temtaime/gitlab:patch-56 into master

What does this MR do?

Set default autocrlf to false to keep user's line endings because gitlab should not modify user input on API calls. Reverts gitlab-foss!858 (merged) because it should use other APIs and/or another mechanism and keep source file line endings.

Fixes #21431 (closed) also needs gitaly!1744 (closed) and omnibus-gitlab!3852 (closed)

Does this MR meet the acceptance criteria?

Yes.

Conformity

Availability and Testing

Security

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports