Add check constraint for new JSONB column diagram_proxy

Asherah Connorrequested to merge
push-mtmvpvmyrvxt into master

What does this MR do and why?

Adds constraint to new JSONB column diagram_proxy (added in Add diagram proxy to route Kroki/PlantUML reque... (!223314 - merged)) to ensure it remains a hash, per https://docs.gitlab.com/development/application_settings/:

  • If there isn’t an existing JSON column which you can use then:

    • Add a new JSON column to the application_settings table to store, see this merge request for reference.

    • Add a constraint to ensure the column always stores a hash, see this merge request for reference.

(emphasis mine)

Supercedes !223315 (closed), which was the stacked MR version of this. It got super noisy with Duo comments as the base changed.

How to set up and validate locally

You could check the branch out and ensure the migration applies up and down cleanly, but I think that's what CI's for.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Asherah Connor

Merge request reports