Skip to content

Fix spacing and UI on Recent Deliveries section of Project Services

What does this MR do?

Issue #118791 (closed)

Example URL: http://localhost:3000/gitlab-org/gitlab-shell/-/services/jenkins/edit

  • Remove negative bottom margin on .footer-block that pushes content up. Add 32px top margin to the Recent Deliveries section.
  • Use .badge instead of .label for the status code to have rounded corners.
  • Use a label method to show just "Error" instead of "internal error" on the frontend.

Screenshots

Before After
Before After

Other places that use .footer-block

Below are a few places that use the .footer-block CSS class. This MR made a change to the bottom margin so below are screenshots to show that those do not have visual regressions. Thankfully, most of them are meant to be at the bottom of the page (aka "footer") so there is only whitespace below.

Edit an MR :group/:project/merge_requests/3/edit

Screen_Shot_2020-01-21_at_16.39.34

Schedule a new pipeline :group/:project/pipeline_schedules/new

Screen_Shot_2020-01-21_at_16.30.00

Admin service templates /admin/application_settings/services/62/edit

Screen_Shot_2020-01-21_at_16.26.27

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports