[Backport 18.9] Fix gitlab:setup failure on fresh database
What does this MR do and why?
Contributes to #591292 (closed)
Problem
Running gitlab:setup on a fresh PostgreSQL database fails with
PG::UndefinedTable: ERROR: relation "feature_gates" does not exist.
This regression was introduced in 18.9 by
!220200 (merged) which added
a circuit breaker to the Gitaly client. The CircuitBreaker#enabled?
method calls Feature.enabled? before the database schema is
initialized, causing Flipper to query the non-existent feature_gates
table.
Solution
Check Feature::FlipperFeature.table_exists? before calling
Feature.enabled? in CircuitBreaker#enabled?. This follows the
established pattern used in lib/feature/gitaly.rb.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
- This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
- The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
- The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
-
Required labels have been applied to this merge request
- severity label and bug subtype labels (if applicable)
- If this MR fixes a bug that affects customers, the customer label has been applied.
- This MR has been approved by a maintainer (only one approval is required).
-
Ensure the
e2e:test-on-omnibus-eejob has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, reach out to a Software Engineer in Test in #s_developer_experience.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releasesSlack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.