Rename SpamCheckService

What does this MR do?

Refactor SpamCheckService to SpamCheckMethods as part of a general tidying of spam handling classes.

Does this MR meet the acceptance criteria?

Conformity

• [-] Changelog entry
• [-] Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• [-] Separation of EE specific content

Availability and Testing

• [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %12.7

added backstage [DEPRECATED] maintenancerefactor spam fighting labels

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Manoj M J (@manojmj)	James Lopez (@jameslopez)

Generated by Danger

assigned to @cablett

added devopsplan + 1 deleted label

added 1 commit

• 57ef1ce0 - Rename SpamCheckService to SpamCheckMethods

Compare with previous version

@syasonik would you please perform backend review?

assigned to @syasonik

unassigned @cablett

changed the description

approved this merge request

Looks lovely! Passing to maintainer.

assigned to @reprazent and unassigned @syasonik

Thanks @cablett! I love cleanup . 2 minor comments.

assigned to @cablett and unassigned @reprazent

added 1 commit

• d40d267e - Move SpamCheckMethods to concerns

Compare with previous version

added 412 commits

• d40d267e...df64d5d2 - 411 commits from branch master
• b9da1dbe - Rename SpamCheckService to SpamCheckMethods

Compare with previous version

changed the description

assigned to @reprazent and unassigned @cablett

resolved all threads

approved this merge request

Thanks @cablett should be good .

merged

mentioned in commit 8ebf18da

mentioned in issue gitlab-com/gl-infra/scalability#95

changed the description

added groupproduct planning label and removed 1 deleted label