Skip to content

Avoid pre-populating form for MR resolve issues

Samantha Ming requested to merge 194764-fix-resolve-thread-in-new-issue into master

Issue: #194764 (closed)

What does this MR do?

Fixes the automatic pre-population from previous issue composition when user clicks on the "resolve thread in new issue" button on a merge request.

Expected Behaviour

  1. Go to a Merge Request with unresolved threads
  2. Click on "Resolve all threads in new issues" OR "Resolve this thread in a new issue"
  3. The MR issue will be pre-populated with:
  • Title > (the title of the MR)
  • Description > (the discussions of the threads that need to be resolved)

_

Problem

  1. In a new tab, create a "New Issue"
  2. Fill in some Title, Description
  3. In a separate tab, go to the Merge Request page
  4. Click "Resolve all threads in new issues" OR "Resolve this thread in a new issue"
  5. 🐞 The "New Issue" page does NOT have the pre-populated information.

_

Testing Case

  1. Go to a Merge Request with unresolved threads
  2. Click on "Resolve all threads in new issues" OR "Resolve this thread in a new issue"

_

The MR issue will be pre-populated with:

  • Title > (the title of the MR)
  • Description > (the discussions of the threads that need to be resolved)
  1. Do not change make any changes.

  2. In a separate tab, go to the Issue page and create a "New issue"

  3. Fill in Title ('hello') and Description ('there')

image

  1. Return back to the MR issue page and refresh the page
  • The title and description should not have changed. (In other words, you should not see what you did in step 5)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #194764 (closed)

Edited by Samantha Ming

Merge request reports