Remove use_job_analytics_deduplicated_finder feature flag
What does this MR do and why?
Cleans up the use_job_analytics_deduplicated_finder feature flag which was used to gate the deduplicated finder (FinishedBuildsDeduplicatedFinder) for CI job analytics during ClickHouse backfill.
The flag has been fully rolled out on production and is stable. This MR removes the feature flag so that QueryBuilder#use_deduplicated_finder? now solely relies on backfill_in_progress? without the additional feature flag guard.
Changes
- Removed the
Feature.enabled?(:use_job_analytics_deduplicated_finder, ...)check fromCi::JobAnalytics::QueryBuilder#use_deduplicated_finder? - Removed the feature flag YAML definition (
config/feature_flags/gitlab_com_derisk/use_job_analytics_deduplicated_finder.yml) - Removed the spec context testing the disabled feature flag state
References
- Feature flag rollout issue: #591429 (closed)
- Original feature issue: #585179 (closed)
- Feature flag introduction MR: !224886 (merged)
Screenshots or screen recordings
N/A - No UI changes.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.