Skip to content

Fix faulty NOT logic for issuable array params

Mario de la Ossa requested to merge 18059-fix-faulty-not-logic into master

What does this MR do?

The way NOT was initially implemented reuses our existing filters and simply inverts them, but these filters when applied to labels and assignees look for the union of all params, and we need it to work as any. This MR fixes that

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Refs #18059 (closed) #198402 (closed)

Edited by Donald Cook

Merge request reports