Allow service account creation for subgroups and projects

Aleksei Lipniagovrequested to merge
586190-al-remove-sa-ffs into master

What does this MR do and why?

Remove feature flags:

  • allow_projects_to_create_service_accounts
  • allow_subgroups_to_create_service_accounts

...to enable service account management in subgroups and projects by default.

Both FFs are globally enabled on .com within %18.10.

These two FFs are tightly coupled, so I see a very little value in splitting this MR per-FF: it will touch the same files all again.

References

allow_projects_to_create_service_accounts rollout issue: https://gitlab.com/gitlab-org/gitlab/-/work_items/586190+

allow_subgroups_to_create_service_accounts rollout issue: https://gitlab.com/gitlab-org/gitlab/-/work_items/582313+

How to set up and validate locally

N/A - FF removal.
Rely on CI and reviews.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #586190

Edited by Aleksei Lipniagov

Merge request reports