Rename secret rotation info for projects

Erick Bajaorequested to merge
eb-group-secrets-rotation-reminder-part-2 into master

Dependent on !225247 (merged) being merged first. Will rebase on master once ready.

What does this MR do and why?

Renames SecretRotationInfo to ProjectSecretRotationInfo for naming consistency with the new GroupSecretRotationInfo model introduced in !225247 (merged), as part of #577344 (closed).

With both project and group rotation info models now inheriting from BaseSecretRotationInfo, the original SecretRotationInfo name was ambiguous. This rename makes it explicit that it's the project-scoped variant, matching the ProjectSecret / GroupSecret naming pattern used elsewhere.

Implementation details

Model rename:

  • SecretsManagement::SecretRotationInfo → SecretsManagement::ProjectSecretRotationInfo
  • File renamed: secret_rotation_info.rb → project_secret_rotation_info.rb
  • Association on Project renamed: has_many :secret_rotation_infos → has_many :project_secret_rotation_infos

STATUSES constant references:

  • GraphQL SecretRotationStatusEnum and all specs now reference BaseSecretRotationInfo::STATUSES instead of SecretRotationInfo::STATUSES, since the constant lives on the base class and is shared by both project and group variants

Factory rename:

  • :secret_rotation_info → :project_secret_rotation_info

No breaking GraphQL changes:

  • graphql_name stays 'SecretRotationInfo' — the public API type name is unchanged
  • All field names, types, nullability, and enum values are identical
  • Only the type description changed from "...for a project secret" to "...for a secret" (documentation only)
  • Verified by running rake gitlab:graphql:generate_all_introspection_schemas — same 3556 types, no schema diff beyond the description string

Series overview

Part of a series for #577344 (closed):

# MR Description
1 !225247 (merged) DB migration + GroupSecretRotationInfo model + BaseSecretRotationInfo base class
2 👉 You are here Rename SecretRotationInfo → ProjectSecretRotationInfo for naming consistency
3 !225562 (merged) CreateService + UpdateService + GraphQL mutations (add rotation_interval_days param)
4 !225935 (merged) List/Read services + GroupSecretType GraphQL type (add rotation info loading/field)
5 !226133 (merged) Background jobs for group and project secret rotation reminders

References

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Erick Bajao

Merge request reports