Resolve "Wiki edit mode layout issues - missing horizontal whitespace"
What does this MR do and why?
Add the same px-3 padding the main content the Wiki has also to the comments, loading, and alert sections.
This is independent of the feature flag wiki_floating_sidebar_toggle or the layout mode (fixed or fluid).
This MR does NOT fix the non-immersive mode of the editor view, as we only work on the immersive view to get this fully done and released.
References
Screenshots or screen recordings
| Before | After |
|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Enable the feature flag
wiki_immersive_editoron http://gdk.test:3000/rails/features or usingrails c. - For the Comments, go to any Wiki page, e.g. http://gdk.test:3000/gitlab-duo/test/-/wikis/home. Resize your browser to meet the spot where the comments are full width in the center panel. Now, there is the same tiny padding on the comments section as on the content above.
- For testing the loading state, go to
app/assets/javascripts/wikis/components/wiki_content.vueand first setisLoadingContenttotrue(loading skeleton), and thenloadingContentFailedtotrue(error state)
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #589400 (closed)
Edited by Vanessa Otto





