WIP: displaying one file at a time when reviewing code
What does this MR do?
When reviewing code, only one file is being displayed at a time. Selecting files is available via the sidebar files-tree, as always.
The reasons I think it's should usually be preferred are:
- very long loading time when we're dealing with PRs with lots of files. You almost can't fix that in any other way, as you have no control over the browser's environment performance (except by dynamically loading files while scrolling, which is less easy to implement and navigate through).
- a crucial part of the Zen-mode, users should have a focused look on code changes.
Currently, this is the major advantage of Crucible over GitLab. Other minor advantages are multiline comments and revisions-slider, both I want to try to implement next.
Any changes and suggestions are welcome, just through it on me.
Related to:
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
It should only have a positive impact on performance. A test that checks navigation between files should be changed or added.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
-
Security reports checked/validated by a reviewer from the AppSec team
Edited by Daniel Gruesso