Fix SA attribution

What does this MR do and why?

This MR fixes incorrect attribution of activities to a service account instead of the human user.

References

Screenshots or screen recordings

Before After

How to set up and validate locally

There's multiple situations where activity was attributed to the SA instead of the human. I suggest testing the following scenarios on the default branch and then on the MR branch.

Service note for assigning and multiple assignees

  1. Create or open an issue, assign a service account such as Duo Developer
  2. Observe that the system note was attributed to the SA and not the human

image

  1. Assign a second Duo account e.g. Duo Code review observe that it does not assign and shows an error

image

  1. Checkout the MR branch and repeats step 2 and 3, observe that they are now attributed to the human and multiple Duo SAs can be assigned to the issue.

Pipeline and commit is attributed to SA

  1. In an issue, click on Create merge request and then Create merge request, unselect Mark as draft and then Create merge request
  2. Change a file or add a commit, observe the commit is attributed to the SA

image

  1. Click on Pipelines tab and observe the pipeline is attributed to the SA

image

  1. Checkout the MR branch repeat steps 1,2 and 3 and observe that they are attributed to the human

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fred de Gier

Merge request reports

Loading