Skip to content

feat: 2FA for admin mode

Diego Louzán requested to merge siemens/gitlab:feat/2fa-for-admin-mode into master

What does this MR do?

Add support for 2FA to admin mode feature. See screenshots below.

  • Supports 2FA for both normal web authentication in gitlab and Omniauth authentication
  • Created new concern Authenticates2FAForAdminMode making use of existing concern AuthenticatesWithTwoFactor
  • Duplicated the views to support customization
  • U2F has been tested with Krypton

Closes #35079 (closed)

🛠 with at Siemens

/cc @bufferoverflow @rpaik @ifarkas @reprazent

Screenshot_2020-03-02_at_20.24.42 Screenshot_2020-03-02_at_20.25.02 Screenshot_2020-03-02_at_20.25.35 Screenshot_2020-03-02_at_20.29.17 Screenshot_2020-03-02_at_20.26.02

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán

Merge request reports