Fix broken rspec for scan profile promotion modal

What does this MR do and why?

Fixes a QA spec by properly handling the scan profile promotion modal that appears on the security configuration page.

MR which introduced the modal: Add scan profile promotional modal (!218117 - merged) • Dheeraj Joshi • 18.9

Broken specs:

Screenshots or screen recordings

Before After

How to set up and validate locally

Enable FF on GDK:

http://gdk.test:3000/rails/features/security_scan_profiles_feature and toggle

Run

❯ WEBDRIVER_HEADLESS=false bundle exec bin/qa Test::Instance::All http://127.0.0.1:3000/ ./qa/specs/features/ee/browser_ui/13_secure/secret_push_protection_spec.rb

Should not fail with

     Failure/Error: config_form.enable_secret_detection

     Selenium::WebDriver::Error::ElementClickInterceptedError:
       element click intercepted: Element <svg data-testid="close-xs-icon" role="img" aria-hidden="true" class="gl-icon s12 gl-fill-current">...</svg> is not clickable at point (283, 776). Other element would receive the click: <div id="scanner-profile-launch-modal" role="dialog" aria-describedby="scanner-profile-launch-modal___BV_modal_body_" class="modal fade show gl-block gl-modal" aria-modal="true" style="">...</div>
         (Session info: chrome=144.0.7559.133)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Will Meek

Merge request reports

Loading