Fix oauth github login flaky e2e test

Hakeem Abdul-Razakrequested to merge
17856-fix_oauth_log_flaky_test into master

Related to https://gitlab.com/gitlab-org/quality/test-failure-issues/-/work_items/17856

What does this MR do and why?

What?

Fixes the OAuth GitHub login flaky E2E test.

Why?

#be_signed_in was returning false. Upon investigation, the flakiness due to it calling #signed_in?(wait: 0) instead of using our Capybara default timeout (timeout = ENV['CI'] || ENV['CI_SERVER'] ? 30 : 10). OAuth flows that work directly with an external provider need retry flows due to network instability (latency, JS rendering time,..). Directly using #has_personal_area? should fix it.

How to set up and validate locally

Verify that the gitlab.com pipelinetier-3 pipelines pass or cd into ./gitlab/qa & run the test locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hakeem Abdul-Razak

Merge request reports