Remove warn mode feature flags on backend

Alexander Turinskerequested to merge
580658-577591-remove-warn-mode-feature-flags into master

What does this MR do and why?

Remove warn mode feature flags on backend

  • feature flag policy_violations_es_filter
  • feature flag security_policy_approval_warn_mode
  • update tests

Changelog: removed

EE: true

References

Screenshots or screen recordings

Page Screenshot
Policy Editor policy_editor
Policy list Policy_list
MR approval mr
MR Bot comment mr_bot_comment
MR bypassed bypassed_policy
Vulnerability List vuln_list

How to set up and validate locally

  1. Upload a GitLab Ultimate license
  2. Navigate to a project => Secure => Policies => New policy => Merge request approval widget
  3. Verify the policy has the enablement section and it defaults to Warn
  4. Verify the only action that can be added is Warn in merge request
  5. Create a warn mode policy that is required on when there are vulnerabilities
  6. Navigate to a project => Secure => Policies => Select the new policy => Verify the drawer says it is a warn mode policy
  7. Create a merge request in the project with vulnerabilities
  8. Verify the MR is blocked by the policy because the pipeline finds the vulnerabilities
  9. Verify the user can override the policy
  10. Merge the MR
  11. Navigate to the project => Secure => Vulnerability report
  12. Verify the vulnerabilities show up in the report with a new badge
  13. Verify a user can filter by these vulnerabilities

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #580658 (closed)

Related to #577591 (closed)

Edited by Alexander Turinske

Merge request reports