Updates .gitlab/ci scripts on 12-4-stable
What does this MR do?
Related to https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8727#note_262807975
Updates .gitlab/
scripts on 12-4-ee-stable
. The following commits were cherry-picked:
- Don't run Review App jobs for backstage changes - Had to be picked otherwise the in preparation for the next commit
- Improve the only/except extendable jobs
- Allow failure for schedule:package-and-qa due to failure rate
Additionally, I had to modify the scripts to fix some failures. These modifications are wrapped on 76c02c45
Test MR on Security https://gitlab.com/gitlab-org/security/gitlab/merge_requests/15
Merge request reports
Activity
changed milestone to %12.7
added Quality backstage [DEPRECATED] security labels
2 Warnings a71b6b9b: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer Engineering Productivity for CI config review Kyle Wiebers ( @kwiebers
)No maintainer available frontend Ragnar Hardarson ( @rhardarson
)Kushal Pandya ( @kushalpandya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖@kwiebers could you please take a look? I've cherry-picked the following commits from
12-5-ee-stable
:- Don't run Review App jobs for backstage changes - Had to be picked otherwise the in preparation for the next commit
- Improve the only/except extendable jobs
- Allow failure for schedule:package-and-qa due to failure rate
Additionally, I had to modify the scripts to fix some failures. These modifications are wrapped on 53886606
I've opened a security MR with the same changes to test them https://gitlab.com/gitlab-org/security/gitlab/merge_requests/15
cc @rspeicher
assigned to @kwiebers
unassigned @mayra-cabrera
- Resolved by Kyle Wiebers
@mayra-cabrera - Thanks for taking care of this this! It looks good to me.
Will there any issue with !22119 (53886606) if we don't need to bring in the commits (631ecf86 and e542863b) which did the equivalent changes to
12-4-ee-stable
? I'm thinking no but just wanted to confirm.I'm sorry that https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8727#note_263201240 wasn't clear about the DRI to resolve.
assigned to @mayra-cabrera and unassigned @kwiebers
There have been a few CI syntax failures on backport stable branches lately that have needed MRs backported.
How can we improve the guidance to identify when to apply
~"Pick into x.y"
on these MRs?@kwiebers This is tricky because stable branches by definition are stuck in the past and thus CI changes/fixes don't necessarily apply well to stable branches... Maybe we need to add a dedicated template for CI config fixes with something like:
- Add the relevant ~"Pick into x.y" (for the last 3 versions if this fix can be applied to the corresponding stable branches
@stanhu could you please take a look? We're backporting some needed changes to the
.gitlab/
scripts from12-5-stable-ee
into12-4-stable-ee
. The changes are needed to fix the error reported onhttps://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8727#note_262807975.There's an MR on security testing these changes https://gitlab.com/gitlab-org/security/gitlab/merge_requests/15
assigned to @stanhu
- Resolved by Mayra Cabrera
Thanks! I can't merge, so I'll either leave that to you or another release manger.
unassigned @stanhu
mentioned in commit 147b43ff
added typemaintenance label