Skip to content
Snippets Groups Projects

Connect options helper in container expiration settings

Merged Nicolò Maria Mezzopera requested to merge 15398-connect-backend-helpers into master

What does this MR do?

In the container registry expiration settings this MR:

  • wires the options helper to generate the options for the input select
  • disable the form elements if the toggle enabled is set to false
  • provide a default value for the select form elements when no value is specified from the user

:warning: this MR is behind feature flag :warning:

This MR picks up the work after !21240 (merged) and continues the work by conecting frontend with backend

Please see #15398 (closed) for the bird eye view issue and &2270 (closed) for the epic containing all the work around this feature

Screenshots

Screenshot_2019-12-19_at_17.07.48

Screenshot_2019-12-19_at_17.08.07

Screenshot_2019-12-20_at_10.38.46

Screencapture

expiration_policies_settings

Caveats

  • the api is not yet returning the default property in the options list, the screenshot are taken by patching the backend manually
  • saving and retrieving the value from the API is not yet functional (if the API is updated while this MR is still being worked on it will be added )

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

part of #15398 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added workflowin review label and removed workflowin dev label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading