Connect options helper in container expiration settings
What does this MR do?
In the container registry expiration settings this MR:
- wires the options helper to generate the options for the input select
- disable the form elements if the toggle
enabled
is set to false - provide a default value for the select form elements when no value is specified from the user
This MR picks up the work after !21240 (merged) and continues the work by conecting frontend with backend
Please see #15398 (closed) for the bird eye view issue and &2270 (closed) for the epic containing all the work around this feature
Screenshots
Screencapture
Caveats
- the api is not yet returning the
default
property in the options list, the screenshot are taken by patching the backend manually - saving and retrieving the value from the API is not yet functional (if the API is updated while this MR is still being worked on it will be added )
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
part of #15398 (closed)
Merge request reports
Activity
changed milestone to %12.7
1 Message CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with:
bin/changelog -m 22112 "Connect options helper in container expiration settings"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 22112 "Connect options helper in container expiration settings"
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Sam Beckham ( @samdbeckham
)Fatih Acet ( @fatihacet
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 2 commits
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
marked the checklist item Tested in all supported browsers as completed
added feature flag label
mentioned in issue #39185 (closed)
- Resolved by Dennis Tang
- Resolved by Nicolò Maria Mezzopera
@dennis Would you like doing frontend review here
? please let me know if you are too busy / at capacity@dimitrieh Would you like doing UX review here
? please let me know if you are too busy / at capacityThe designs that this MR contribute to implement can be found here ( cancel and save button have been added after a conversation with @icamacho )
Edited by Nicolò Maria Mezzopera
assigned to @dennis and @dimitrieh
added workflowin review label and removed workflowin dev label
- Resolved by Nicolò Maria Mezzopera
@marcel.amirault could you give this a review as well? I wonder if the button should follow sentence case here or not, see https://design.gitlab.com/content/punctuation
assigned to @marcel.amirault