Skip to content

Rename template jobs for SAST and DS

Can Eldem requested to merge fix-conflict-dast-ds into master

What does this MR do?

Both DS and SAST jobs has template job called .analyzer . .analyzer will be used when we disable docker in docker

.analyzer:
  extends: (dependency_scanning  sast)
  script:
    - /analyzer run

Because both jobs has same template name it causes wrong arfifact to be uploded when both DS and SAST is use in no docker in docker mode. Here is sample config that might cause problem

  DS_DISABLE_DIND: "true"
  SAST_DISABLE_DIND: "true"

stages:
  - test

include:
  - template: Security/Dependency-Scanning.gitlab-ci.yml   
  - template: Security/SAST.gitlab-ci.yml 

Related Issue

#38134 (closed)

Screenshots

Previously failing project using templates in this MR

https://gitlab.com/caneldem/test-removing-dind image

Another test, used multi pipeline to trigger test projects with different languages this is how it works

image

This is the result (rails-test has warning related to nodejs, not related to the issue this MR trying to solve)

https://gitlab.com/caneldem/remove-dind/pipelines/104317013

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec tea
Edited by 🤖 GitLab Bot 🤖

Merge request reports