Skip to content

Change name of TestClass in 2 spec files

Reuben Pereira requested to merge fix-test-class into master

What does this MR do?

Since qualified_domain_array_validator_spec.rb and spec/models/concerns/safe_url_spec.rb used the same name for a Class (TestClass), they caused order dependent spec failures like https://gitlab.com/gitlab-org/gitlab/-/jobs/383000878

The minimal command to reproduce the spec failures on local is:

rspec -fd ./spec/validators/qualified_domain_array_validator_spec.rb[1:1:1:1,1:1:3] ./spec/models/concerns/safe_url_spec.rb[1:1:1]

This MR renames the TestClass in both specs.

Issue: #118833 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports