Skip to content

Show regular rules without approvers

Igor Drozdov requested to merge display-rules-without-approvers into master

What does this MR do?

Currently, we don't display regular rules without approvers on UI. Such regular rule can appear when the rule has only an author of the MR as an approver, but the authors aren't allowed to approve. As a result, the following steps reproduce this issue:

  • Set Prevent approval of merge requests by merge request author on the Project settings
  • Add Only author regular rule to an MR with only the author as an approver
  • Save
  • Edit again -> the rule is not displayed
  • Try to add Only author regular rule -> Error

We started hiding the rules because we wanted such MRs to use fallback rule, but since we've introduced the any-approver rule, I don't think we need this behavior. We can revert it and then fix the problem with regular rules which have no visible approvers separately.

Related:

Merge request reports