Hide composite identity service accounts without associated triggers from MR reviewers dropdown
What does this MR do and why?
Hide composite identity service accounts without associated triggers from MR reviewers dropdown.
This is desirable because assigning these service accounts will not trigger any flows and may confuse users. We only want to show actionable users (service accounts) there.
This MR only addresses MRs reviewers. A follow-up MR will address MR assignees and other types of interactions like issues assignment and mentioning a service account to trigger flows.
References
Related to #584613
Screenshots or screen recordings
| Before | After |
|---|---|
|
|
How to set up and validate locally
-
Enable Code Review foundational flow for a group with Duo Pro enabled: E.g. http://gdk.test:3000/groups/gitlab-duo/-/edit#js-gitlab-duo-settings
- This will enable the flow for all projects under that group, but since Duo Code Review doesn't have flow triggers, the service account should be hidden
-
Go to a MR and try to add the service account to the reviewers list
- The service account should not show on the dropdown
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.