Separate subscriptions into their own welcome controller
What does this MR do and why?
- simplifying logic and making code more maintainable
- see https://gitlab.com/gitlab-org/gitlab/-/work_items/590049
Screenshots/recordings
no change
How to set up and validate locally
note basically trying to emulate feature spec steps in ee/spec/features/registrations/saas/subscription_*
Requires CDOT setup locally
- Setup to simulate SaaS and restart GDK
- Enable the
refactored_subscription_welcomefeature flag - Go to
http://gdk.test:3000/-/subscriptions/new?plan_id=2c92a0ff76f0d5250176f2f8c86f305ain an unsigned in browser window - Register as a new user.
- Ensure registration flow goes as expected and redirects to the subscription process
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to https://gitlab.com/gitlab-org/gitlab/-/work_items/590049
Edited by Doug Stull