Skip to content
Snippets Groups Projects

Do not post entire Wiki page content as chat notification

Merged Ville Skyttä requested to merge scop/gitlab:wiki-page-message into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for fixing the tests and adding a clear spec. Looks good to me - I have just made one very minor comment, but I'm happy to pass this along to a maintainer.

    Thanks for the contribution @scop!

  • Alex Kalderimis marked the checklist item Documentation (if required) as completed

    marked the checklist item Documentation (if required) as completed

  • Alex Kalderimis marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Alex Kalderimis marked the checklist item Merge request performance guidelines as completed

    marked the checklist item Merge request performance guidelines as completed

  • Alex Kalderimis marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Alex Kalderimis marked the checklist item Database guides as completed

    marked the checklist item Database guides as completed

  • Alex Kalderimis marked the checklist item Separation of EE specific content as completed

    marked the checklist item Separation of EE specific content as completed

  • @scop, would you be able to add a changelog entry? This can be done with:

    ./bin/changelog -m 21722 -t changed

    From the repository root. Oh, and now would be a great time to rebase on master - we are nearly 900 commits behind master at this point.

    @stanhu - would you be able to do a maintainer review here?

    Edited by Alex Kalderimis
  • Alex Kalderimis approved this merge request

    approved this merge request

  • assigned to @stanhu

  • Ville Skyttä resolved all threads

    resolved all threads

  • Ville Skyttä added 1 commit

    added 1 commit

    • e59e5fc3 - Apply suggestion to spec/models/project_services/chat_message/wiki_page_message_spec.rb

    Compare with previous version

  • Ville Skyttä added 887 commits

    added 887 commits

    • e59e5fc3...43323f0c - 886 commits from branch gitlab-org:master
    • 682ba57a - Include commit message instead of entire page in Wiki chat notifications

    Compare with previous version

  • unassigned @scop

  • Stan Hu approved this merge request

    approved this merge request

  • Stan Hu resolved all threads

    resolved all threads

  • Stan Hu changed milestone to %12.7

    changed milestone to %12.7

  • Stan Hu enabled an automatic merge when the pipeline for 682ba57a succeeds

    enabled an automatic merge when the pipeline for 682ba57a succeeds

  • Thanks @scop!

  • merged

  • Stan Hu mentioned in commit 2ebc694f

    mentioned in commit 2ebc694f

  • This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.7.201912220505-12520e50379.f6955f076a3.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.7.201912220606-248aecd290c.cefd1447c9c.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowcanary label and removed workflowstaging label

  • This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.7.201912220606-248aecd290c.cefd1447c9c.

    A list of all the deployed commits can be found here.


    :robot: If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowproduction label and removed workflowcanary label

  • mentioned in commit 7816adee

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • 🤖 GitLab Bot 🤖 added groupeditor [DEPRECATED] label and removed 1 deleted label

    added groupeditor [DEPRECATED] label and removed 1 deleted label

  • Please register or sign in to reply
    Loading