Do not post entire Wiki page content as chat notification
What does this MR do?
See #20812 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Merge request reports
Activity
mentioned in issue #20812 (closed)
added Community contribution label
mentioned in issue #103413 (closed)
added 1st contribution label
added Category:Wiki devopsmanage labels
@lmcandrew could you assign this to a reviewer?
assigned to @lmcandrew
- Resolved by Luke Duncalfe
@.luke @alexkalderimis @dsatcher putting this MR on your radar!
added devopscreate + 1 deleted label and removed devopsmanage label
unassigned @lmcandrew
assigned to @dsatcher
assigned to @.luke
unassigned @dsatcher
@scop Thanks for this contribution!
Could you also update the spec for the class, as the change has a red pipeline due to the failures printed the bottom of this job.
I'm going to be away for two weeks. If this change is next ready for review before the 6th January, please could you alert @alexkalderimis to review it, otherwise please send it back to me! Thank you!
Edited by Luke Duncalfeadded 1 commit
- e3a28407 - Update Wiki page chat message spec for changed content
Don't know if I got it right, guess we'll see :)
Ping @alexkalderimis as requested, I think I'm not able to reassign this to you myself.
Thanks @scop - I'll take a look
assigned to @alexkalderimis
- Resolved by Ville Skyttä
Thanks for fixing the tests and adding a clear spec. Looks good to me - I have just made one very minor comment, but I'm happy to pass this along to a maintainer.
Thanks for the contribution @scop!
marked the checklist item Documentation (if required) as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Database guides as completed
marked the checklist item Separation of EE specific content as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
@scop, would you be able to add a changelog entry? This can be done with:
./bin/changelog -m 21722 -t changed
From the repository root. Oh, and now would be a great time to rebase on master - we are nearly 900 commits behind master at this point.
@stanhu - would you be able to do a maintainer review here?
Edited by Alex Kalderimisassigned to @stanhu
added 1 commit
- e59e5fc3 - Apply suggestion to spec/models/project_services/chat_message/wiki_page_message_spec.rb
- Resolved by Stan Hu
Rebased, squashed, and added changelog.
added 887 commits
-
e59e5fc3...43323f0c - 886 commits from branch
gitlab-org:master
- 682ba57a - Include commit message instead of entire page in Wiki chat notifications
-
e59e5fc3...43323f0c - 886 commits from branch
unassigned @scop
changed milestone to %12.7
enabled an automatic merge when the pipeline for 682ba57a succeeds
Thanks @scop!
mentioned in commit 2ebc694f
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.7.201912220505-12520e50379.f6955f076a3
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.7.201912220606-248aecd290c.cefd1447c9c
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.7.201912220606-248aecd290c.cefd1447c9c
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
mentioned in commit 7816adee
added groupeditor [DEPRECATED] label and removed 1 deleted label
mentioned in issue #20811 (closed)