Skip to content

Do not clean the prometheus metrics directory for sidekiq

David Wilkins requested to merge dwilkins/gitlab:37387-do-not-clean-sidekiq-metrics into master

What does this MR do?

Stop cleaning the prometheus metrics directory for sidekiq processes

  • sidekiq-cluster starts multiple processes, each with the same prometheus metrics directory

  • Processes that are created later can delete files (essentially make them invisible) that were created by earlier processes

  • Some of the deleted files become invisible to the sidekiq exporter and metrics are under-reported for sidekiq-cluster installations.

  • omnibus-gitlab cleans the metrics directory before starting sidekiq and sidekiq-cluster. This negates the need for the directory being cleaned by the application

Screenshots

In the issue #37387 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Risk to on-prem customers that are NOT using our omnibus scripts (gitlab-ctl) to manage the sidekiq processes. If the metrics directories are not being deleted upon restart, then metrics may accumulate

omnibus-gitlab manages the deletion of the metrics directory outside of the application.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports