chore: rename User#full_private_access? to User#can_read_all_resources?
What does this MR do?
Solve some technical debt by renaming User#full_private_access? to User#can_read_all_resources?. As part of the admin mode feature, we refactored this to use the policies framework, and can_read_all_resources? reflects much better the intended permission: administrators (and in EE auditors) have read access to all resources.
We follow the same approach as existing method User#can_create_group? to rename this one which also uses policies.
Closes #34856 (closed)
/cc @bufferoverflow @rpaik @reprazent @ifarkas
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán