Skip to content

Display error message in codeclimate widget when base_path is null

What does this MR do?

When there is no codequality artifact available for the base pipeline of a merge request, in the codequality MR widget, display Failed to load codeclimate report along with a question mark icon which displays Base pipeline codequality artifact not found on hover.

Technically, this MR

  • changes shouldRenderCodeQuality() to return true even when base_path is null in order to display the MR widget
  • sets the loadingCodequalityFailed flag to true when base_path is null to show the existing error message inside the widget
  • adds a popover prop to the codequality <report-section /> specifically when base_path is null in order to show a question mark icon with a popover that displays the more specific error message and a link to the docs

Screenshots

before [codeclimate widget was not displayed at all]
after Screen_Shot_2020-01-08_at_19.16.17
after (hover) Screen_Shot_2020-01-13_at_14.32.39

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related: #14033 (closed)

Edited by Miranda Fluharty

Merge request reports

Loading