Finalize audit event streaming BBMs
What does this MR do and why?
Finalizes all outstanding batched background migrations (BBMs) related to audit event streaming destination backfills. These migrations have been running since 17.10-18.6 and have reached 100% completion on GitLab.com.
Finalizing these BBMs is a prerequisite for:
Removing the legacy audit event destination tables Removing the legacy models and associated code Cleaning up the sync helpers that maintain parity between old and new tables
BBMs being finalized
| Migration | Queued In | Table |
|---|---|---|
BackfillExternalInstanceAuditEventDestinations |
17.10 | audit_events_instance_external_audit_event_destinations |
BackfillExternalGroupAuditEventDestinations |
17.11 | audit_events_external_audit_event_destinations |
BackfillGoogleGroupAuditEventDestinations |
17.11 | audit_events_google_cloud_logging_configurations |
BackfillGoogleInstanceAuditEventDestinations |
17.11 | audit_events_instance_google_cloud_logging_configurations |
BackfillAmazonGroupAuditEventDestinations |
17.11 | audit_events_amazon_s3_configurations |
BackfillAmazonInstanceAuditEventDestinations |
17.11 | audit_events_instance_amazon_s3_configurations |
BackfillExternalGroupAuditEventDestinationsFixed |
18.0 | audit_events_external_audit_event_destinations |
BackfillExternalInstanceAuditEventDestinationsFixed |
18.0 | audit_events_instance_external_audit_event_destinations |
FixIncompleteInstanceExternalAuditDestinationsV2 |
18.6 | audit_events_instance_external_audit_event_destinations |
FixIncompleteGroupExternalAuditDestinationsV2 |
18.6 | audit_events_external_audit_event_destinations |
Note on skip_early_finalization_validation
Migrations use skip_early_finalization_validation: true because they were queued after the last required stop (18.5), these BBMs are confirmed complete on production (100%) and I'd like to start removing legacy behaviour/cleanup code as it gets harder to debug/as it grows/etc.
References
Screenshots or screen recordings
| Before | After |
|---|---|
How to set up and validate locally
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.