Skip to content

Hide mirror admin actions from developers

What does this MR do?

To trigger a pull or push mirror update, you need to be a project admin. However, we show the link to developers at the moment.

This is an issue for both pull and push mirrors.

Fix it by hiding the link if it's going to 404.

Screenshots

Developer or administrator before:

Screenshot_from_2019-12-19_19-05-18

Does this MR meet the acceptance criteria?

Anonymous:

Screenshot_from_2019-12-19_19-20-06

Developer after:

Screenshot_from_2019-12-19_19-49-43

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #35305 (closed)

Edited by Mayra Cabrera

Merge request reports

Loading