Auth requests with job token as auth header
requested to merge 22465-rack-attack-authenticate-runner-requests-with-job-token-basic-auth into master
What does this MR do?
Fixes Admin Area > Settings > Network > User and IP Rate Limits
throttles so that runner requests using a valid job token as HTTP basic auth header will now be counted in Authenticated API request rate limit
and not in Unauthenticated request rate limit
.
related issue #22465 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino