[FF] Cleanup group_owner_placeholder_confirmation_bypass
What does this MR do and why?
The ability in Direct Transfer for group owners to skip confirmation of placeholder user assignments has been enabled globally for a few milestones.
This MR deletes the feature flag group_owner_placeholder_confirmation_bypass which was previously gating the feature:
- no longer check feature flag in order for the setting to be available/usable for a group
- updates docs
References
Clean up issue -> #569771
Epic -> &17871
Screenshots or screen recordings
Unchanged
How to set up and validate locally
- Make sure your instance is on the premium or ultimate plan. Instructions here
- Make sure the group you want to test has EE features https://docs.gitlab.com/development/ee_features/#simulate-a-saas-instance
- On the left sidebar, at the bottom, select Admin. If you’ve turned on the new navigation, in the upper-right corner, select Admin.
- On the left sidebar, select Overview > Groups.
- Identify the group you want to modify, and select Edit.
- Scroll to Permissions and group features. For Plan, select
Ultimate. - Select Save changes.
- Simulate Gitlab.com being true by running
GITLAB_SIMULATE_SAAS=1 gdk restart - Visit the group settings page. It has to be a top-level (root) group not subgroup. Eg.
http://127.0.0.1:3000/groups/flightjs/-/edit - Scroll down to the 'Permissions and group features' section. You should see the checkbox under 'Placeholder user confirmation'
- Click the checkbox and save.
- OPTIONAL - Not recommended: The actual skipping of user confirmation happens in the direct transfer process https://docs.gitlab.com/user/group/import/ . It requires migrating another group into your chosen group following direct transfer, then assigning contributions to an enterprise user following https://docs.gitlab.com/user/import/mapping/#reassign-contributions-and-memberships.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #569771
Edited by Oiza Baiye
