Skip to content

Add code quality tab with full report to pipeline view

Miranda Fluharty requested to merge mfluharty-full-codequality-report into master

What does this MR do?

This MR adds a tab to the pipeline view that displays all of the codequality issues that were found when the pipeline was run

Documentation MR: !23138 (closed)

Screenshots

Screenshot_2020-01-15_Pipeline___Administrator_test-codequality

Testing locally

I have created a code quality testing project with a basic pipeline that copies a JSON file into the spot where a code quality artifact would be in a "real" pipeline. Clone that project, run a pipeline, and the new report should show up in the new Code Quality tab once the pipeline runs.

Caveat: the issues themselves are exported from the main gitlab project, so the links in the list that should go to the file with the code quality violation will instead just take you to the repo's file view and display a message at the top saying that the file doesn't exist. This is expected when testing with this repo because the link goes to where the file would be if it existed.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related: #4189 (closed)

Edited by Miranda Fluharty

Merge request reports